Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO QA needed - Update Configure-Quickbooks-Online.md #49766

Merged
merged 1 commit into from
Sep 27, 2024
Merged

NO QA needed - Update Configure-Quickbooks-Online.md #49766

merged 1 commit into from
Sep 27, 2024

Conversation

jliexpensify
Copy link
Contributor

Copied info from Connect doc to Configure.

Details

Fixed Issues

$
PROPOSAL:

@jliexpensify
Update Configure-Quickbooks-Online.md
9780188 
Copied info from Connect doc to Configure.
@jliexpensify jliexpensify self-assigned this Sep 26, 2024
@jliexpensify jliexpensify requested a review from a team as a code owner September 26, 2024 04:14
@melvin-bot melvin-bot bot requested review from neil-marcellini and removed request for a team September 26, 2024 04:14
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 26, 2024

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify
Copy link
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://81ce5a17.helpdot.pages.dev ⚡️

neil-marcellini
neil-marcellini approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@neil-marcellini
Copy link
Contributor

Merging with author and reviewer checklist failing because we don't need to do that for theses help documentation changes

@neil-marcellini neil-marcellini merged commit 2b791c9 into main Sep 27, 2024
7 of 9 checks passed
@neil-marcellini neil-marcellini deleted the jliexpensify-patch-1 branch September 27, 2024 18:45
@melvin-bot melvin-bot bot added the Emergency label Sep 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 27, 2024

@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.41-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.41-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

shikharx06 pushed a commit to shikharx06/App that referenced this pull request Oct 18, 2024
Revert "Merge pull request Expensify#49766 from Expensify/jliexpensif…
56cbc83 
…y-patch-1"

This reverts commit 2b791c9, reversing
changes made to 4c4e83e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neil-marcellini neil-marcellini neil-marcellini approved these changes

Assignees

@jliexpensify jliexpensify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jliexpensify @OSBotify @neil-marcellini